Skip to content

Fix build for Jenkins and GCC 4.7. #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 9, 2015
Merged

Fix build for Jenkins and GCC 4.7. #347

merged 2 commits into from
Jul 9, 2015

Conversation

egavrin
Copy link
Contributor

@egavrin egavrin commented Jul 9, 2015

Seams that #291 fix was reverted by later commits.

JerryScript-DCO-1.0-Signed-off-by: Evgeny Gavrin [email protected]

@egavrin egavrin added the bug Undesired behaviour label Jul 9, 2015
@seanshpark seanshpark mentioned this pull request Jul 9, 2015
Merged
@egavrin egavrin force-pushed the fix-build-gcc-4.7 branch 5 times, most recently from b5c1da7 to cff255d Compare July 9, 2015 08:58
@egavrin egavrin added the critical Raises security concerns label Jul 9, 2015
@egavrin egavrin force-pushed the fix-build-gcc-4.7 branch 7 times, most recently from c68e514 to 31b163b Compare July 9, 2015 10:02
@egavrin egavrin changed the title Fix build for GCC 4.7. Fix build for Jenkins and GCC 4.7. Jul 9, 2015
@egavrin egavrin force-pushed the fix-build-gcc-4.7 branch 2 times, most recently from 8764819 to 9bca792 Compare July 9, 2015 10:32
@sand1k
Copy link
Contributor

sand1k commented Jul 9, 2015

LGTM.

@egavrin egavrin assigned LaszloLango and unassigned sand1k Jul 9, 2015
galpeter
galpeter reviewed Jul 9, 2015
View reviewed changes
build/configs/toolchain_linux_armv7l-el.cmake
@@ -17,5 +17,7 @@ set(CMAKE_SYSTEM_PROCESSOR armv7l-el)

set(CMAKE_C_COMPILER arm-linux-gnueabi-gcc)
set(CMAKE_CXX_COMPILER arm-linux-gnueabi-g++)
# FIXME: This could break cross compilation, when the strip is not for the target architecture
find_program(CMAKE_STRIP NAMES arm-linux-gnueabi-strip arm-linux-gnueabi-strip strip)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think arm-linux-gnueabi-strip is needed twice.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugly copy-paste. Fixed.

@LaszloLango LaszloLango assigned galpeter and unassigned LaszloLango Jul 9, 2015
@egavrin egavrin force-pushed the fix-build-gcc-4.7 branch from 9bca792 to eec3c86 Compare July 9, 2015 12:26
@egavrin
Copy link
Contributor Author

egavrin commented Jul 9, 2015

@galpeter fixed.

@galpeter
Copy link
Contributor

galpeter commented Jul 9, 2015

lgtm

egavrin added 2 commits July 9, 2015 15:38
@egavrin
Fix strip handling for cross build configurations.
a26832f 
JerryScript-DCO-1.0-Signed-off-by: Evgeny Gavrin [email protected]
@egavrin
Fix build for GCC 4.7.
9c18648 
JerryScript-DCO-1.0-Signed-off-by: Evgeny Gavrin [email protected]
@egavrin egavrin force-pushed the fix-build-gcc-4.7 branch from eec3c86 to 9c18648 Compare July 9, 2015 12:38
@egavrin egavrin merged commit 9c18648 into master Jul 9, 2015
@egavrin egavrin deleted the fix-build-gcc-4.7 branch July 9, 2015 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Undesired behaviour critical Raises security concerns
Projects
None yet
Milestone
Maintenance of ECMA functionality
Development

Successfully merging this pull request may close these issues.
4 participants
@egavrin @sand1k @galpeter @LaszloLango